Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bypass load permission if migrations not completed #178

Merged
merged 1 commit into from
May 26, 2023
Merged

fix: bypass load permission if migrations not completed #178

merged 1 commit into from
May 26, 2023

Conversation

navinkarkera
Copy link
Contributor

Description

This MR fixes tutor build failure due to permissions file being loaded before migrations. The fix is inspired by #145

Testing instructions

Install this plugin in tutor and run tutor images build openedx, it will fail with database ImproperlyConfigured error. Update your local copy of plugin with this change and run build, it should work.

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@Alec4r
Copy link
Member

Alec4r commented May 10, 2023

Hi!! @navinkarkera,

We are planning to add this review in our next sprint, we will make test in a remote environment,

I hope have good news for you soon.

Thanks for the PR.

@navinkarkera navinkarkera mentioned this pull request May 16, 2023
Merged
4 tasks
MaferMazu
MaferMazu approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. And this implements something similar to #145

What do you think @Alec4r @JuanDavidBuitrago @dcoa @luisfelipec95?

MaferMazu
MaferMazu approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. And this implements something similar to #145

What do you think @Alec4r @JuanDavidBuitrago @dcoa @luisfelipec95?

JuanDavidBuitrago
JuanDavidBuitrago approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@JuanDavidBuitrago JuanDavidBuitrago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! It's similar as you say @MaferMazu

@JuanDavidBuitrago
Copy link
Member

@Alec4r, @MaferMazu how we can continue with this? It is blocked for unsigned commits.

@MaferMazu
Copy link
Contributor

I didn't notice that we need signed commits 🙈

@navinkarkera, can you sign this commit to merge this?

@navinkarkera navinkarkera force-pushed the navin/fix-build-issue branch from e1941d7 to f424cbb Compare May 26, 2023 06:19
@navinkarkera
Copy link
Contributor Author

I didn't notice that we need signed commits see_no_evil

@navinkarkera, can you sign this commit to merge this?

@MaferMazu Done.

@JuanDavidBuitrago JuanDavidBuitrago merged commit 3d518be into eduNEXT:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanDavidBuitrago JuanDavidBuitrago JuanDavidBuitrago approved these changes

@MaferMazu MaferMazu MaferMazu approved these changes

@Alec4r Alec4r Awaiting requested review from Alec4r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navinkarkera @Alec4r @JuanDavidBuitrago @MaferMazu